Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Push Notification provider configuration related APIs #776

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ZiyamSanthosh
Copy link
Contributor

This PR will introduce the admin APIs to configure Push Notification provider configurations.

application/json:
schema:
$ref: '#/components/schemas/Error'
"405":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the 405

Comment on lines +636 to +639
"401":
description: Unauthorized
"403":
description: Forbidden
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add the error body

provider: FCM
properties:
- key: FCM.serviceAccount
value: {"FCMUrl": "UrlValue"}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
value: {"FCMUrl": "UrlValue"}
value: "UrlValue"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update other similar examples

application/json:
schema:
$ref: '#/components/schemas/Error'
"405":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do the same for other places

Comment on lines +755 to +758
"401":
description: Unauthorized
"403":
description: Forbidden
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add the response body

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do the same for other places

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants